Remove unused framelayout in postview

also make hasoverlappingrendering return false, optimization
filtering
Floens 10 years ago
parent a270c6af6e
commit 2e2335c5b2
  1. 15
      Clover/app/src/main/java/org/floens/chan/ui/cell/PostCell.java
  2. 25
      Clover/app/src/main/res/layout/cell_post.xml
  3. 1
      Clover/app/src/main/res/values/attrs.xml
  4. 1
      Clover/app/src/main/res/values/styles.xml

@ -17,10 +17,12 @@
*/ */
package org.floens.chan.ui.cell; package org.floens.chan.ui.cell;
import android.annotation.TargetApi;
import android.content.Context; import android.content.Context;
import android.content.res.TypedArray; import android.content.res.TypedArray;
import android.graphics.Typeface; import android.graphics.Typeface;
import android.graphics.drawable.BitmapDrawable; import android.graphics.drawable.BitmapDrawable;
import android.os.Build;
import android.support.annotation.NonNull; import android.support.annotation.NonNull;
import android.text.Layout; import android.text.Layout;
import android.text.Spannable; import android.text.Spannable;
@ -37,7 +39,6 @@ import android.text.style.StyleSpan;
import android.util.AttributeSet; import android.util.AttributeSet;
import android.view.MotionEvent; import android.view.MotionEvent;
import android.view.View; import android.view.View;
import android.widget.FrameLayout;
import android.widget.ImageView; import android.widget.ImageView;
import android.widget.RelativeLayout; import android.widget.RelativeLayout;
import android.widget.TextView; import android.widget.TextView;
@ -72,7 +73,6 @@ public class PostCell extends RelativeLayout implements PostLinkable.Callback {
private Post post; private Post post;
private boolean threadMode; private boolean threadMode;
private FrameLayout thumbnailViewContainer;
private ThumbnailView thumbnailView; private ThumbnailView thumbnailView;
private TextView title; private TextView title;
private TextView icons; private TextView icons;
@ -123,7 +123,6 @@ public class PostCell extends RelativeLayout implements PostLinkable.Callback {
protected void onFinishInflate() { protected void onFinishInflate() {
super.onFinishInflate(); super.onFinishInflate();
thumbnailViewContainer = (FrameLayout) findViewById(R.id.thumbnail_container);
thumbnailView = (ThumbnailView) findViewById(R.id.thumbnail_view); thumbnailView = (ThumbnailView) findViewById(R.id.thumbnail_view);
title = (TextView) findViewById(R.id.title); title = (TextView) findViewById(R.id.title);
icons = (TextView) findViewById(R.id.icons); icons = (TextView) findViewById(R.id.icons);
@ -247,6 +246,12 @@ public class PostCell extends RelativeLayout implements PostLinkable.Callback {
return thumbnailView; return thumbnailView;
} }
@Override
@TargetApi(Build.VERSION_CODES.JELLY_BEAN)
public boolean hasOverlappingRendering() {
return false;
}
private void bindPost(Post post) { private void bindPost(Post post) {
threadMode = callback.getLoadable().isThreadMode(); threadMode = callback.getLoadable().isThreadMode();
@ -269,10 +274,10 @@ public class PostCell extends RelativeLayout implements PostLinkable.Callback {
} }
if (post.hasImage) { if (post.hasImage) {
thumbnailViewContainer.setVisibility(View.VISIBLE); thumbnailView.setVisibility(View.VISIBLE);
thumbnailView.setUrl(post.thumbnailUrl, thumbnailView.getLayoutParams().width, thumbnailView.getLayoutParams().height); thumbnailView.setUrl(post.thumbnailUrl, thumbnailView.getLayoutParams().width, thumbnailView.getLayoutParams().height);
} else { } else {
thumbnailViewContainer.setVisibility(View.GONE); thumbnailView.setVisibility(View.GONE);
thumbnailView.setUrl(null, 0, 0); thumbnailView.setUrl(null, 0, 0);
} }

@ -20,20 +20,11 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
android:layout_width="match_parent" android:layout_width="match_parent"
android:layout_height="wrap_content"> android:layout_height="wrap_content">
<FrameLayout <org.floens.chan.ui.view.ThumbnailView
android:id="@+id/thumbnail_container" android:id="@+id/thumbnail_view"
android:layout_width="72dp" android:layout_width="72dp"
android:layout_height="match_parent" android:layout_height="72dp"
android:layout_alignParentTop="true" android:gravity="top" />
android:background="?post_thumbnail_background">
<org.floens.chan.ui.view.ThumbnailView
android:id="@+id/thumbnail_view"
android:layout_width="72dp"
android:layout_height="72dp"
android:gravity="top" />
</FrameLayout>
<TextView <TextView
android:id="@+id/title" android:id="@+id/title"
@ -42,7 +33,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
android:layout_alignParentRight="true" android:layout_alignParentRight="true"
android:layout_alignParentTop="true" android:layout_alignParentTop="true"
android:layout_alignWithParentIfMissing="true" android:layout_alignWithParentIfMissing="true"
android:layout_toRightOf="@id/thumbnail_container" android:layout_toRightOf="@id/thumbnail_view"
android:paddingRight="25dp" /> android:paddingRight="25dp" />
<TextView <TextView
@ -52,7 +43,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
android:layout_alignParentRight="true" android:layout_alignParentRight="true"
android:layout_alignWithParentIfMissing="true" android:layout_alignWithParentIfMissing="true"
android:layout_below="@id/title" android:layout_below="@id/title"
android:layout_toRightOf="@id/thumbnail_container" /> android:layout_toRightOf="@id/thumbnail_view" />
<TextView <TextView
android:id="@+id/comment" android:id="@+id/comment"
@ -61,7 +52,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
android:layout_alignParentRight="true" android:layout_alignParentRight="true"
android:layout_alignWithParentIfMissing="true" android:layout_alignWithParentIfMissing="true"
android:layout_below="@id/icons" android:layout_below="@id/icons"
android:layout_toRightOf="@id/thumbnail_container" /> android:layout_toRightOf="@id/thumbnail_view" />
<TextView <TextView
android:id="@+id/replies" android:id="@+id/replies"
@ -69,7 +60,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
android:layout_height="wrap_content" android:layout_height="wrap_content"
android:layout_alignWithParentIfMissing="true" android:layout_alignWithParentIfMissing="true"
android:layout_below="@id/comment" android:layout_below="@id/comment"
android:layout_toRightOf="@id/thumbnail_container" android:layout_toRightOf="@id/thumbnail_view"
android:singleLine="true" android:singleLine="true"
android:textColor="?attr/post_reply_count_color" /> android:textColor="?attr/post_reply_count_color" />

@ -82,7 +82,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
<attr name="backcolor" format="color" /> <attr name="backcolor" format="color" />
<attr name="post_thumbnail_background" format="color" />
<attr name="post_saved_reply_color" format="color" /> <attr name="post_saved_reply_color" format="color" />
<attr name="post_highlighted_color" format="color" /> <attr name="post_highlighted_color" format="color" />
<attr name="post_reply_count_color" format="color" /> <attr name="post_reply_count_color" format="color" />

@ -36,7 +36,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
<item name="text_color_secondary">#89000000</item> <item name="text_color_secondary">#89000000</item>
<item name="text_color_hint">#42000000</item> <item name="text_color_hint">#42000000</item>
<item name="post_thumbnail_background">#FFDDDDDD</item>
<item name="post_saved_reply_color">#FFBCBCBC</item> <item name="post_saved_reply_color">#FFBCBCBC</item>
<item name="post_highlighted_color">#FFD6BAD0</item> <item name="post_highlighted_color">#FFD6BAD0</item>
<item name="post_reply_count_color">#FF646464</item> <item name="post_reply_count_color">#FF646464</item>

Loading…
Cancel
Save