From 2e2335c5b22ef1e655cf98f0de297189deba3909 Mon Sep 17 00:00:00 2001
From: Floens <floens@gmail.com>
Date: Tue, 19 May 2015 20:26:27 +0200
Subject: [PATCH] Remove unused framelayout in postview also make
 hasoverlappingrendering return false, optimization

---
 .../org/floens/chan/ui/cell/PostCell.java     | 15 +++++++----
 Clover/app/src/main/res/layout/cell_post.xml  | 25 ++++++-------------
 Clover/app/src/main/res/values/attrs.xml      |  1 -
 Clover/app/src/main/res/values/styles.xml     |  1 -
 4 files changed, 18 insertions(+), 24 deletions(-)

diff --git a/Clover/app/src/main/java/org/floens/chan/ui/cell/PostCell.java b/Clover/app/src/main/java/org/floens/chan/ui/cell/PostCell.java
index 2780f159..9981f5eb 100644
--- a/Clover/app/src/main/java/org/floens/chan/ui/cell/PostCell.java
+++ b/Clover/app/src/main/java/org/floens/chan/ui/cell/PostCell.java
@@ -17,10 +17,12 @@
  */
 package org.floens.chan.ui.cell;
 
+import android.annotation.TargetApi;
 import android.content.Context;
 import android.content.res.TypedArray;
 import android.graphics.Typeface;
 import android.graphics.drawable.BitmapDrawable;
+import android.os.Build;
 import android.support.annotation.NonNull;
 import android.text.Layout;
 import android.text.Spannable;
@@ -37,7 +39,6 @@ import android.text.style.StyleSpan;
 import android.util.AttributeSet;
 import android.view.MotionEvent;
 import android.view.View;
-import android.widget.FrameLayout;
 import android.widget.ImageView;
 import android.widget.RelativeLayout;
 import android.widget.TextView;
@@ -72,7 +73,6 @@ public class PostCell extends RelativeLayout implements PostLinkable.Callback {
     private Post post;
     private boolean threadMode;
 
-    private FrameLayout thumbnailViewContainer;
     private ThumbnailView thumbnailView;
     private TextView title;
     private TextView icons;
@@ -123,7 +123,6 @@ public class PostCell extends RelativeLayout implements PostLinkable.Callback {
     protected void onFinishInflate() {
         super.onFinishInflate();
 
-        thumbnailViewContainer = (FrameLayout) findViewById(R.id.thumbnail_container);
         thumbnailView = (ThumbnailView) findViewById(R.id.thumbnail_view);
         title = (TextView) findViewById(R.id.title);
         icons = (TextView) findViewById(R.id.icons);
@@ -247,6 +246,12 @@ public class PostCell extends RelativeLayout implements PostLinkable.Callback {
         return thumbnailView;
     }
 
+    @Override
+    @TargetApi(Build.VERSION_CODES.JELLY_BEAN)
+    public boolean hasOverlappingRendering() {
+        return false;
+    }
+
     private void bindPost(Post post) {
         threadMode = callback.getLoadable().isThreadMode();
 
@@ -269,10 +274,10 @@ public class PostCell extends RelativeLayout implements PostLinkable.Callback {
         }
 
         if (post.hasImage) {
-            thumbnailViewContainer.setVisibility(View.VISIBLE);
+            thumbnailView.setVisibility(View.VISIBLE);
             thumbnailView.setUrl(post.thumbnailUrl, thumbnailView.getLayoutParams().width, thumbnailView.getLayoutParams().height);
         } else {
-            thumbnailViewContainer.setVisibility(View.GONE);
+            thumbnailView.setVisibility(View.GONE);
             thumbnailView.setUrl(null, 0, 0);
         }
 
diff --git a/Clover/app/src/main/res/layout/cell_post.xml b/Clover/app/src/main/res/layout/cell_post.xml
index 31105d38..6c92b0fa 100644
--- a/Clover/app/src/main/res/layout/cell_post.xml
+++ b/Clover/app/src/main/res/layout/cell_post.xml
@@ -20,20 +20,11 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
     android:layout_width="match_parent"
     android:layout_height="wrap_content">
 
-    <FrameLayout
-        android:id="@+id/thumbnail_container"
+    <org.floens.chan.ui.view.ThumbnailView
+        android:id="@+id/thumbnail_view"
         android:layout_width="72dp"
-        android:layout_height="match_parent"
-        android:layout_alignParentTop="true"
-        android:background="?post_thumbnail_background">
-
-        <org.floens.chan.ui.view.ThumbnailView
-            android:id="@+id/thumbnail_view"
-            android:layout_width="72dp"
-            android:layout_height="72dp"
-            android:gravity="top" />
-
-    </FrameLayout>
+        android:layout_height="72dp"
+        android:gravity="top" />
 
     <TextView
         android:id="@+id/title"
@@ -42,7 +33,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         android:layout_alignParentRight="true"
         android:layout_alignParentTop="true"
         android:layout_alignWithParentIfMissing="true"
-        android:layout_toRightOf="@id/thumbnail_container"
+        android:layout_toRightOf="@id/thumbnail_view"
         android:paddingRight="25dp" />
 
     <TextView
@@ -52,7 +43,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         android:layout_alignParentRight="true"
         android:layout_alignWithParentIfMissing="true"
         android:layout_below="@id/title"
-        android:layout_toRightOf="@id/thumbnail_container" />
+        android:layout_toRightOf="@id/thumbnail_view" />
 
     <TextView
         android:id="@+id/comment"
@@ -61,7 +52,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         android:layout_alignParentRight="true"
         android:layout_alignWithParentIfMissing="true"
         android:layout_below="@id/icons"
-        android:layout_toRightOf="@id/thumbnail_container" />
+        android:layout_toRightOf="@id/thumbnail_view" />
 
     <TextView
         android:id="@+id/replies"
@@ -69,7 +60,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         android:layout_height="wrap_content"
         android:layout_alignWithParentIfMissing="true"
         android:layout_below="@id/comment"
-        android:layout_toRightOf="@id/thumbnail_container"
+        android:layout_toRightOf="@id/thumbnail_view"
         android:singleLine="true"
         android:textColor="?attr/post_reply_count_color" />
 
diff --git a/Clover/app/src/main/res/values/attrs.xml b/Clover/app/src/main/res/values/attrs.xml
index d2dcfdc0..35c180a1 100644
--- a/Clover/app/src/main/res/values/attrs.xml
+++ b/Clover/app/src/main/res/values/attrs.xml
@@ -82,7 +82,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
     <attr name="backcolor" format="color" />
 
-    <attr name="post_thumbnail_background" format="color" />
     <attr name="post_saved_reply_color" format="color" />
     <attr name="post_highlighted_color" format="color" />
     <attr name="post_reply_count_color" format="color" />
diff --git a/Clover/app/src/main/res/values/styles.xml b/Clover/app/src/main/res/values/styles.xml
index 4f23ebc4..9c662107 100644
--- a/Clover/app/src/main/res/values/styles.xml
+++ b/Clover/app/src/main/res/values/styles.xml
@@ -36,7 +36,6 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         <item name="text_color_secondary">#89000000</item>
         <item name="text_color_hint">#42000000</item>
 
-        <item name="post_thumbnail_background">#FFDDDDDD</item>
         <item name="post_saved_reply_color">#FFBCBCBC</item>
         <item name="post_highlighted_color">#FFD6BAD0</item>
         <item name="post_reply_count_color">#FF646464</item>