Better theme restarting

Clover/app/src/main/java/org/floens/chan/ui/activity/BaseActivity.java

@@ -59,6 +59,8 @@ import org.floens.chan.utils.Utils;
 import java.util.List;
 
 public abstract class BaseActivity extends Activity implements PanelSlideListener, PinnedManager.PinListener {
+    public static boolean doRestartOnResume = false;
+
     private final static int ACTION_OPEN_URL = 1;
 
     protected PinnedAdapter pinnedAdapter;
@@ -112,6 +114,16 @@ public abstract class BaseActivity extends Activity implements PanelSlideListene
         ChanApplication.getPinnedManager().removePinListener(this);
     }
 
+    @Override
+    protected void onResume() {
+        super.onResume();
+
+        if (doRestartOnResume) {
+            doRestartOnResume = false;
+            recreate();
+        }
+    }
+
     private void initPane() {
         threadPane.setPanelSlideListener(this);
         threadPane.setParallaxDistance(200);

Clover/app/src/main/java/org/floens/chan/ui/activity/SettingsActivity.java

@@ -47,24 +47,18 @@ public class SettingsActivity extends Activity {
         doingThemeRestart = true;
         startActivity(intent);
         finish();
+        doingThemeRestart = false;
         overridePendingTransition(android.R.anim.fade_in, android.R.anim.fade_out);
     }
 
     @Override
-    protected void onDestroy() {
+    protected void onPause() {
-        super.onDestroy();
+        super.onPause();
 
-        if (doingThemeRestart) {
+        if (ThemeHelper.getInstance().getTheme() != lastTheme) {
-            doingThemeRestart = false;
+            lastTheme = ThemeHelper.getInstance().getTheme();
-        } else {
-            if (ThemeHelper.getInstance().getTheme() != lastTheme) {
-                lastTheme = ThemeHelper.getInstance().getTheme();
-
-                Intent intent = new Intent(this, BoardActivity.class);
-                intent.setFlags(Intent.FLAG_ACTIVITY_NEW_TASK | Intent.FLAG_ACTIVITY_CLEAR_TASK);
 
-                startActivity(intent);
+            BaseActivity.doRestartOnResume = true;
-            }
         }
     }
 }