Post review fixes

Clover/app/src/main/java/org/floens/chan/core/presenter/ReplyPresenter.java

@@ -279,6 +279,8 @@ public class ReplyPresenter implements AuthenticationLayoutCallback, ImagePickDe
     public void onAuthenticationComplete(AuthenticationLayoutInterface authenticationLayout, String challenge, String response) {
         draft.captchaChallenge = challenge;
         draft.captchaResponse = response;
+
+        // should this be called here?
         authenticationLayout.reset();
         makeSubmitCall();
     }

Clover/app/src/main/java/org/floens/chan/ui/captcha/v2/CaptchaNoJsV2Adapter.java

@@ -16,6 +16,8 @@ import java.util.ArrayList;
 import java.util.List;
 
 public class CaptchaNoJsV2Adapter extends BaseAdapter {
+    private static final int ANIMATION_DURATION = 50;
+
     private LayoutInflater inflater;
     private int imageSize = 0;
 
@@ -65,7 +67,7 @@ public class CaptchaNoJsV2Adapter extends BaseAdapter {
                 imageList.get(position).toggleChecked();
                 boolean isChecked = imageList.get(position).isChecked;
 
-                AndroidUtils.animateViewScale(imageView, isChecked);
+                AndroidUtils.animateViewScale(imageView, isChecked, ANIMATION_DURATION);
                 blueCheckmark.setVisibility(isChecked ? View.VISIBLE : View.GONE);
             });
 

Clover/app/src/main/java/org/floens/chan/utils/AndroidUtils.java

@@ -455,7 +455,7 @@ public class AndroidUtils {
         return networkInfo != null && networkInfo.isConnected();
     }
 
-    public static void animateViewScale(View view, boolean zoomOut) {
+    public static void animateViewScale(View view, boolean zoomOut, int duration) {
         ScaleAnimation scaleAnimation;
         final float normalScale = 1.0f;
         final float zoomOutScale = 0.8f;
@@ -482,7 +482,7 @@ public class AndroidUtils {
                     0.5f);
         }
 
-        scaleAnimation.setDuration(50);
+        scaleAnimation.setDuration(duration);
         scaleAnimation.setFillAfter(true);
         scaleAnimation.setInterpolator(new AccelerateDecelerateInterpolator());
 

Clover/app/src/main/res/drawable/background_rectangle.xml

@@ -1,4 +0,0 @@
-<shape xmlns:android="http://schemas.android.com/apk/res/android" android:shape="rectangle" >
-    <solid android:color="@android:color/white" />
-    <stroke android:width="1dip" android:color="@color/accent"/>
-</shape>

Clover/app/src/main/res/layout/layout_captcha_challenge_image.xml

@@ -9,8 +9,6 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:scaleType="fitXY"
-        android:layout_margin="2dp"
-        android:background="@drawable/background_rectangle"
         app:layout_constraintBottom_toBottomOf="parent"
         app:layout_constraintEnd_toEndOf="parent"
         app:layout_constraintStart_toStartOf="parent"

Clover/app/src/main/res/values/strings.xml

@@ -583,5 +583,5 @@ Don't have a 4chan Pass?<br>
     <string name="captcha_layout_v2_you_have_to_select_at_least_one_image" tools:ignore="MissingTranslation">You have to selected at least one image (if you see a captcha that does not have any matching images then it is probably a bug fill an issue and use old captcha for a while)</string>
     <string name="captcha_layout_v2_verification_already_in_progress" tools:ignore="MissingTranslation">Verification is already in progress</string>
     <string name="captcha_layout_v2_captcha_request_is_already_in_progress" tools:ignore="MissingTranslation">Captcha request is already in progress</string>
-    <string name="captcha_layout_v2_you_are_requesting_captcha_too_fast" translatable="false">You are requesting captcha too fast</string>
+    <string name="captcha_layout_v2_you_are_requesting_captcha_too_fast" tools:ignore="MissingTranslation">You are requesting captcha too fast</string>
 </resources>