add setting for default video mute state

refactor-toolbar
Floens 8 years ago
parent 34d7d021e2
commit 272f02258a
  1. 4
      Clover/app/src/main/java/org/floens/chan/core/presenter/ImageViewerPresenter.java
  2. 2
      Clover/app/src/main/java/org/floens/chan/core/settings/ChanSettings.java
  3. 4
      Clover/app/src/main/java/org/floens/chan/ui/controller/MediaSettingsController.java
  4. 2
      Clover/app/src/main/res/values/strings.xml

@ -58,11 +58,13 @@ public class ImageViewerPresenter implements MultiImageView.Callback, ViewPager.
private boolean viewPagerVisible = false; private boolean viewPagerVisible = false;
private boolean changeViewsOnInTransitionEnd = false; private boolean changeViewsOnInTransitionEnd = false;
private boolean muted = true; private boolean muted;
public ImageViewerPresenter(Callback callback) { public ImageViewerPresenter(Callback callback) {
this.callback = callback; this.callback = callback;
inject(this); inject(this);
muted = ChanSettings.videoDefaultMuted.get();
} }
public void showImages(List<PostImage> images, int position, Loadable loadable) { public void showImages(List<PostImage> images, int position, Loadable loadable) {

@ -131,6 +131,7 @@ public class ChanSettings {
public static final BooleanSetting neverHideToolbar; public static final BooleanSetting neverHideToolbar;
public static final BooleanSetting controllerSwipeable; public static final BooleanSetting controllerSwipeable;
public static final BooleanSetting saveBoardFolder; public static final BooleanSetting saveBoardFolder;
public static final BooleanSetting videoDefaultMuted;
public static final BooleanSetting watchEnabled; public static final BooleanSetting watchEnabled;
public static final BooleanSetting watchCountdown; public static final BooleanSetting watchCountdown;
@ -207,6 +208,7 @@ public class ChanSettings {
neverHideToolbar = new BooleanSetting(p, "preference_never_hide_toolbar", false); neverHideToolbar = new BooleanSetting(p, "preference_never_hide_toolbar", false);
controllerSwipeable = new BooleanSetting(p, "preference_controller_swipeable", true); controllerSwipeable = new BooleanSetting(p, "preference_controller_swipeable", true);
saveBoardFolder = new BooleanSetting(p, "preference_save_subboard", false); saveBoardFolder = new BooleanSetting(p, "preference_save_subboard", false);
videoDefaultMuted = new BooleanSetting(p, "preference_video_default_muted", true);
watchEnabled = new BooleanSetting(p, "preference_watch_enabled", false); watchEnabled = new BooleanSetting(p, "preference_watch_enabled", false);
watchEnabled.addCallback((setting, value) -> watchEnabled.addCallback((setting, value) ->

@ -101,6 +101,10 @@ public class MediaSettingsController extends SettingsController {
R.string.setting_save_original_filename, R.string.setting_save_original_filename,
R.string.setting_save_original_filename_description)); R.string.setting_save_original_filename_description));
media.add(new BooleanSettingView(this, ChanSettings.videoDefaultMuted,
R.string.setting_video_default_muted,
R.string.setting_video_default_muted_description));
media.add(new BooleanSettingView(this, ChanSettings.videoOpenExternal, media.add(new BooleanSettingView(this, ChanSettings.videoOpenExternal,
R.string.setting_video_open_external, R.string.setting_video_open_external,
R.string.setting_video_open_external_description)); R.string.setting_video_open_external_description));

@ -520,6 +520,8 @@ Re-enable this permission in the app settings if you permanently disabled it."</
<string name="setting_save_original_filename">Save original filename</string> <string name="setting_save_original_filename">Save original filename</string>
<string name="setting_save_original_filename_description">Save the image with the filename the site assigned. <string name="setting_save_original_filename_description">Save the image with the filename the site assigned.
If disabled, save the image with the filename from the uploader.</string> If disabled, save the image with the filename from the uploader.</string>
<string name="setting_video_default_muted">Start videos muted</string>
<string name="setting_video_default_muted_description">If a video has audio, mute it by default.</string>
<string name="setting_video_open_external">Open videos external</string> <string name="setting_video_open_external">Open videos external</string>
<string name="setting_video_open_external_description">Open videos in an external media player</string> <string name="setting_video_open_external_description">Open videos in an external media player</string>
<string name="setting_share_url">Share url to image</string> <string name="setting_share_url">Share url to image</string>

Loading…
Cancel
Save