From 2e100f63e982e9446f6d28352fc60c0d5485296d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Lorenz=20H=C3=BCbschle-Schneider?=
 <lorenz-dev@lgh-alumni.de>
Date: Tue, 25 Nov 2014 16:38:30 +0100
Subject: [PATCH] Fix links and embeds

Disable semi-broken plugins
---
 index.html           |  4 ++--
 js/filters.js        | 10 +++++++++-
 js/plugins.js        |  4 +++-
 test/unit/plugins.js |  2 ++
 4 files changed, 16 insertions(+), 4 deletions(-)

diff --git a/index.html b/index.html
index 55da213..aaee4c7 100644
--- a/index.html
+++ b/index.html
@@ -185,7 +185,7 @@
           </a>
           <button ng-if="debugMode" ng-click="countWatchers()">Count<br />Watchers</button>
         </div>
-        <div class="title" ng-bind-html="activeBuffer().title | linky:'_blank' | DOMfilter:'irclinky'" title="{{activeBuffer().title}}"></div>
+        <div class="title" ng-bind-html="activeBuffer().title | linky:'_system' | linksForCordova | DOMfilter:'irclinky'" title="{{activeBuffer().title}}"></div>
         <div class="actions pull-right vertical-line-left">
           <div class="pull-left">
             <a class="settings-toggle" ng-click="showModal('settingsModal')" title="Options menu">
@@ -240,7 +240,7 @@
               <td class="prefix"><a ng-click="addMention(bufferline.prefix)"><span ng-repeat="part in ::bufferline.prefix" ng-class="::part.classes" ng-bind="::part.text"></span></a></td><!--
            --><td class="message"><!--
              --><div ng-repeat="metadata in ::bufferline.metadata" plugin data="::metadata"></div><!--
-             --><span ng-repeat="part in ::bufferline.content" class="text" ng-class="::part.classes" ng-bind-html="::part.text | linky:'_blank' | DOMfilter:'irclinky' | DOMfilter:'inlinecolour'"></span>
+             --><span ng-repeat="part in ::bufferline.content" class="text" ng-class="::part.classes" ng-bind-html="::part.text | linky:'_system' | linksForCordova | DOMfilter:'irclinky' | DOMfilter:'inlinecolour'"></span>
               </td>
             </tr>
             <tr class="readmarker" ng-if="activeBuffer().lastSeen==$index">
diff --git a/js/filters.js b/js/filters.js
index 3ca8297..b82178f 100644
--- a/js/filters.js
+++ b/js/filters.js
@@ -103,6 +103,15 @@ weechat.filter('DOMfilter', ['$filter', '$sce', function($filter, $sce) {
     };
 }]);
 
+weechat.filter('linksForCordova', ['$sce', function($sce) {
+    return function (text) {
+        // Cordova: need to use window.open instead of href
+        // XXX TODO this needs to be improved
+        text = text.replace(/<a (?:target="_[a-z]+"\s)?href="([^"]+)"/gi, "<a onClick=\"window.open('$1', '_system')\"");
+        return $sce.trustAsHtml(text);
+    };
+}]);
+
 weechat.filter('getBufferQuickKeys', function () {
     return function (obj, $scope) {
         if (!$scope) { return obj; }
@@ -124,5 +133,4 @@ weechat.filter('getBufferQuickKeys', function () {
         return obj;
     };
 });
-
 })();
diff --git a/js/plugins.js b/js/plugins.js
index 88d9cae..d1b7d95 100644
--- a/js/plugins.js
+++ b/js/plugins.js
@@ -338,6 +338,7 @@ plugins.factory('userPlugins', function() {
     );
     yrPlugin.name = "meteogram";
 
+/*
     // Embed GitHub gists
     var gistPlugin = new Plugin(
         urlPlugin(function(url) {
@@ -390,9 +391,10 @@ plugins.factory('userPlugins', function() {
         })
     );
     tweetPlugin.name = 'Tweet';
+*/
 
     return {
-        plugins: [youtubePlugin, dailymotionPlugin, allocinePlugin, imagePlugin, spotifyPlugin, cloudmusicPlugin, googlemapPlugin, asciinemaPlugin, yrPlugin, gistPlugin, tweetPlugin]
+        plugins: [youtubePlugin, dailymotionPlugin, allocinePlugin, imagePlugin, spotifyPlugin, cloudmusicPlugin, googlemapPlugin, asciinemaPlugin, yrPlugin]
     };
 
 
diff --git a/test/unit/plugins.js b/test/unit/plugins.js
index 774e724..0e22980 100644
--- a/test/unit/plugins.js
+++ b/test/unit/plugins.js
@@ -119,6 +119,7 @@ describe('filter', function() {
             plugins);
         }));
 
+/*
         it('should recognize gists', inject(function(plugins) {
             expectTheseMessagesToContain([
                 'https://gist.github.com/lorenzhs/e8c1a7d56fa170320eb8',
@@ -135,6 +136,7 @@ describe('filter', function() {
             'Tweet',
             plugins);
         }));
+*/
 
     });
 });