From 19c408ba13cd3da965b8d013134dc65087c366ba Mon Sep 17 00:00:00 2001 From: Patrick Melanson Date: Thu, 7 Jan 2016 18:03:48 -0500 Subject: [PATCH] #705 bugfix datechange injected under read marker after #708 was merged, if a date change message is injected underneath the read marker the read marker would be one line too low. Now, the read marker will adjust properly when a date change message is injected above and below the read marker. thanks lorenzhs for spotting that --- js/handlers.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/js/handlers.js b/js/handlers.js index 0b3ea2f..ceab76e 100644 --- a/js/handlers.js +++ b/js/handlers.js @@ -50,7 +50,11 @@ weechat.factory('handlers', ['$rootScope', '$log', 'models', 'plugins', 'notific new_date.setHours(0, 0, 0, 0); // Check if the date changed if (old_date.valueOf() !== new_date.valueOf()) { - ++buffer.lastSeen; + if (buffer.lastSeen + 1 < buffer.lines.length) { + // if the date change should be injected below the read marker, + // adjust the read marker up to make sure it stays under the read marker + ++buffer.lastSeen; + } var old_date_plus_one = old_date; old_date_plus_one.setDate(old_date.getDate() + 1); // it's not always true that a date with time 00:00:00