From 012bd882587d6463b7138bb1cb1843d95b76fe5c Mon Sep 17 00:00:00 2001
From: Jeremy Mahieu <JeremyM@dynamics.be>
Date: Thu, 19 Dec 2019 22:16:01 +0100
Subject: [PATCH] Change layout and autoconnect behaviour. Add info next to
 topt function

---
 index.html        | 24 ++++++++++++++++--------
 js/connection.js  |  8 +++++++-
 js/glowingbear.js |  5 ++---
 3 files changed, 25 insertions(+), 12 deletions(-)

diff --git a/index.html b/index.html
index 3da29a8..e66f13c 100644
--- a/index.html
+++ b/index.html
@@ -100,21 +100,31 @@
             <div class="panel-body">
                <form class="form-signin" role="form">
                 <div class="form-group">
-                  <label class="control-label" for="host">WeeChat relay hostname and port number</label>
+
                   <div class="input-group">
                     <div class="row no-gutter">
                       <div class="col-sm-9">
+                        <label class="control-label" for="host">WeeChat relay hostname</label>
                         <input type="text" class="form-control favorite-font" id="host" ng-model="settings.hostField" ng-change="parseHost()" ng-class="{'is-invalid': hostInvalid}" placeholder="Address" autocapitalize="off">
                       </div>
                       <div class="col-sm-3">
+                        <label class="control-label" for="port">Port</label>
                         <input type="text" class="form-control favorite-font" id="port" ng-model="settings.port" ng-disabled="portDisabled" placeholder="Port">
                       </div>
                     </div>
                   </div>
-                  <label class="control-label" for="password">WeeChat relay password</label>
-                  <input type="password" class="form-control favorite-font" id="password" ng-model="password" placeholder="Password">
+                  <div class="row no-gutter">
+                    <div ng-class="settings.useTotp ? 'col-sm-9' : 'col-sm-12'" ng>
+                      <label class="control-label" for="password">WeeChat relay password</label>
+                      <input type="password" class="form-control favorite-font" id="password" ng-model="password" placeholder="Password">
+                    </div>
+                    <div class="col-sm-3" ng-Show="settings.useTotp">
+                      <label class="control-label" for="totp">Token</label>
+                      <input type="text" class="form-control favorite-font" id="totp" ng-model="totp" autocomplete="off">
+                    </div>
+                  </div>
                   <div class="alert alert-danger" ng-show="passwordError" ng-cloak>
-                    Error: wrong password or one-time password
+                    Error: wrong password or token
                   </div>
 
                   <div class="checkbox">
@@ -137,12 +147,10 @@
                   </div>
                   <div class="checkbox">
                     <label class="control-label" for="useTotp">
-                      <input type="checkbox" id="useTotp" ng-model="settings.useTotp" ng-change="changeUseTOTP()">
-                      Use Time-based One-Time Password
+                      <input type="checkbox" id="useTotp" ng-model="settings.useTotp">
+                      Use Time-based One-Time Password <a href="https://blog.weechat.org/post/2019/01/14/Support-of-TOTP">ℹ️</a>
                     </label>
                   </div>
-                  <label class="control-label" for="totp" ng-Show="settings.useTotp">One time password</label>
-                  <input type="text" class="form-control favorite-font" id="totp" ng-model="totp" ng-Show="settings.useTotp" ng-model="totp" autocomplete="off">
                 </div>
                 <button class="btn btn-lg btn-primary" ng-disabled="hostInvalid" ng-click="connect()" ng-cloak>{{ connectbutton }}  <i ng-class="connectbuttonicon" class="glyphicon"></i></button>
               </form>
diff --git a/js/connection.js b/js/connection.js
index d84ac76..b521332 100644
--- a/js/connection.js
+++ b/js/connection.js
@@ -328,9 +328,15 @@ weechat.factory('connection',
     };
 
     var attemptReconnect = function (bufferId, timeout) {
+        // won't work if totp is mandatory
+        if (settings.useTotp)
+        {
+            $log.info('Not reconnecting because totp will be expired.');
+            return;
+        }
+
         $log.info('Attempting to reconnect...');
         var d = connectionData;
-        // won't work if totp is mandatory
         connect(d[0], d[1], d[2], d[3], d[4], false, "", function() {
             $rootScope.reconnecting = false;
             // on success, update active buffer
diff --git a/js/glowingbear.js b/js/glowingbear.js
index a139787..d85114c 100644
--- a/js/glowingbear.js
+++ b/js/glowingbear.js
@@ -688,12 +688,11 @@ weechat.controller('WeechatCtrl', ['$rootScope', '$scope', '$store', '$timeout',
         }
     };
 
-    $scope.changeUseTOTP = function() {
+    settings.addCallback('useTotp', function() {
         if (settings.useTotp) {
             settings.autoconnect = false;
         }
-    };
-
+    });
 
     $scope.connect = function() {
         notifications.requestNotificationPermission();