Fix dropdown colors and change some toolbar icons

Clover/app/src/main/java/org/floens/chan/ui/activity/ChanActivity.java

@@ -709,14 +709,24 @@ public class ChanActivity extends BaseActivity implements AdapterView.OnItemSele
             }
         }
 
+        @Override
+        public View getDropDownView(int position, View convertView, ViewGroup parent) {
+            return createView(position, convertView, parent, true);
+        }
+
         @Override
         public View getView(final int position, View convertView, final ViewGroup parent) {
+            return createView(position, convertView, parent, false);
+        }
+
+        private View createView(int position, View convertView, ViewGroup parent, boolean dropDown) {
             if (position == getCount() - 1) {
-                TextView textView = (TextView) LayoutInflater.from(context).inflate(R.layout.board_select_add, null);
+                TextView textView = (TextView) LayoutInflater.from(context).inflate(R.layout.board_select_add, parent, false);
                 textView.setText(getItem(position));
                 return textView;
             } else {
-                TextView textView = (TextView) LayoutInflater.from(context).inflate(R.layout.board_select_spinner, null);
+                TextView textView = (TextView) LayoutInflater.from(context).inflate(
+                        dropDown ? R.layout.board_select_spinner_dropdown : R.layout.board_select_spinner, parent, false);
                 textView.setText(getItem(position));
                 return textView;
             }

Clover/app/src/main/res/layout/board_select_spinner.xml

@@ -22,7 +22,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
     android:textSize="16sp"
-    android:textColor="#FFF3F3F3"
+    android:textColor="#ffffffff"
     android:gravity="center_vertical"
     android:paddingLeft="?android:attr/listPreferredItemPaddingLeft"
     android:paddingRight="?android:attr/listPreferredItemPaddingRight"

Clover/app/src/main/res/layout/board_select_spinner_dropdown.xml

@@ -0,0 +1,31 @@
+<?xml version="1.0" encoding="utf-8"?>
+<!--
+Clover - 4chan browser https://github.com/Floens/Clover/
+Copyright (C) 2014  Floens
+
+This program is free software: you can redistribute it and/or modify
+it under the terms of the GNU General Public License as published by
+the Free Software Foundation, either version 3 of the License, or
+(at your option) any later version.
+
+This program is distributed in the hope that it will be useful,
+but WITHOUT ANY WARRANTY; without even the implied warranty of
+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+GNU General Public License for more details.
+
+You should have received a copy of the GNU General Public License
+along with this program.  If not, see <http://www.gnu.org/licenses/>.
+-->
+<TextView
+    xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@android:id/text1"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content"
+    android:textSize="16sp"
+    android:textColor="#ff000000"
+    android:gravity="center_vertical"
+    android:paddingLeft="?android:attr/listPreferredItemPaddingLeft"
+    android:paddingRight="?android:attr/listPreferredItemPaddingRight"
+    android:minHeight="?android:attr/listPreferredItemHeightSmall"
+    android:singleLine="true"
+    android:ellipsize="end"/>

Clover/app/src/main/res/layout/toolbar.xml

@@ -16,7 +16,11 @@ You should have received a copy of the GNU General Public License
 along with this program.  If not, see <http://www.gnu.org/licenses/>.
 -->
 <android.support.v7.widget.Toolbar xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto"
     android:id="@+id/toolbar"
     android:layout_width="match_parent"
     android:layout_height="wrap_content"
-    android:background="?attr/colorPrimary" />
+    android:minHeight="?attr/actionBarSize"
+    android:background="?attr/colorPrimary"
+    app:theme="@style/ThemeOverlay.AppCompat.Dark.ActionBar"
+    app:popupTheme="@style/ThemeOverlay.AppCompat.Light" />

Clover/app/src/main/res/menu/base.xml

@@ -15,12 +15,13 @@ GNU General Public License for more details.
 You should have received a copy of the GNU General Public License
 along with this program.  If not, see <http://www.gnu.org/licenses/>.
 -->
-<menu xmlns:android="http://schemas.android.com/apk/res/android">
+<menu xmlns:android="http://schemas.android.com/apk/res/android"
+    xmlns:app="http://schemas.android.com/apk/res-auto">
     <item
         android:id="@+id/action_reload_tablet"
         android:icon="@drawable/ic_action_refresh"
         android:orderInCategory="1"
-        android:showAsAction="always"
+        app:showAsAction="always"
         android:title="@string/action_reload">
         <menu>
             <item
@@ -36,28 +37,28 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         android:id="@+id/action_reload_board"
         android:icon="@drawable/ic_action_refresh"
         android:orderInCategory="1"
-        android:showAsAction="always"
+        app:showAsAction="always"
         android:title="@string/action_reload_board" />
 
     <item
         android:id="@+id/action_pin"
         android:icon="@drawable/ic_action_make_available_offline"
         android:orderInCategory="2"
-        android:showAsAction="always"
+        app:showAsAction="always"
         android:title="@string/action_pin" />
 
     <item
         android:id="@+id/action_reply"
-        android:icon="@drawable/ic_action_chat"
+        android:icon="@drawable/ic_action_write"
         android:orderInCategory="4"
-        android:showAsAction="ifRoom"
+        app:showAsAction="ifRoom"
         android:title="@string/action_reply" />
 
     <item
         android:id="@+id/action_reply_tablet"
-        android:icon="@drawable/ic_action_chat"
+        android:icon="@drawable/ic_action_write"
         android:orderInCategory="4"
-        android:showAsAction="ifRoom"
+        app:showAsAction="ifRoom"
         android:title="@string/action_reply">
         <menu>
             <item
@@ -74,7 +75,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         android:id="@+id/action_reload_thread"
         android:icon="@drawable/ic_action_refresh"
         android:orderInCategory="5"
-        android:showAsAction="never"
+        app:showAsAction="never"
         android:title="@string/action_reload" />
 
     <item
@@ -85,7 +86,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
     <item
         android:id="@+id/action_search_tablet"
         android:orderInCategory="6"
-        android:showAsAction="never"
+        app:showAsAction="never"
         android:title="@string/action_search">
         <menu>
             <item
@@ -102,19 +103,19 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
         android:id="@+id/action_share"
         android:actionProviderClass="android.widget.ShareActionProvider"
         android:orderInCategory="7"
-        android:showAsAction="never"
+        app:showAsAction="never"
         android:title="@string/action_share" />
 
     <item
         android:id="@+id/action_open_browser"
         android:orderInCategory="8"
-        android:showAsAction="never"
+        app:showAsAction="never"
         android:title="@string/action_open_browser" />
 
     <item
         android:id="@+id/action_board_view_mode"
         android:orderInCategory="9"
-        android:showAsAction="never"
+        app:showAsAction="never"
         android:title="@string/action_board_view_mode">
         <menu>
             <group android:checkableBehavior="single">
@@ -131,7 +132,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
     <item
         android:id="@+id/action_settings"
         android:orderInCategory="100"
-        android:showAsAction="never"
+        app:showAsAction="never"
         android:title="@string/action_settings" />
 
 </menu>