diff --git a/Clover/app/src/main/java/org/floens/chan/core/manager/ThreadManager.java b/Clover/app/src/main/java/org/floens/chan/core/manager/ThreadManager.java index a56fd9f9..55505aef 100644 --- a/Clover/app/src/main/java/org/floens/chan/core/manager/ThreadManager.java +++ b/Clover/app/src/main/java/org/floens/chan/core/manager/ThreadManager.java @@ -433,7 +433,7 @@ public class ThreadManager implements Loader.LoaderListener { private void showPostReply(PostLinkable linkable) { String value = linkable.value; - Post post = null; + Post post; try { // Get post id @@ -542,7 +542,7 @@ public class ThreadManager implements Loader.LoaderListener { dialog.dismiss(); if (response.isNetworkError || response.isUserError) { - int resId = 0; + int resId; if (response.isTooSoonError) { resId = R.string.delete_too_soon; diff --git a/Clover/app/src/main/java/org/floens/chan/core/net/ChanReaderRequest.java b/Clover/app/src/main/java/org/floens/chan/core/net/ChanReaderRequest.java index 32fd3a3d..9dbcbcf0 100644 --- a/Clover/app/src/main/java/org/floens/chan/core/net/ChanReaderRequest.java +++ b/Clover/app/src/main/java/org/floens/chan/core/net/ChanReaderRequest.java @@ -68,7 +68,7 @@ public class ChanReaderRequest extends JsonReaderRequest> { @Override public List readJson(JsonReader reader) { - List list = new ArrayList<>(); + List list; if (loadable.isBoardMode()) { list = loadBoard(reader); diff --git a/Clover/app/src/main/java/org/floens/chan/ui/ScrollerRunnable.java b/Clover/app/src/main/java/org/floens/chan/ui/ScrollerRunnable.java index fc9924f2..93c082d8 100644 --- a/Clover/app/src/main/java/org/floens/chan/ui/ScrollerRunnable.java +++ b/Clover/app/src/main/java/org/floens/chan/ui/ScrollerRunnable.java @@ -46,7 +46,7 @@ public class ScrollerRunnable implements Runnable { final int firstPos = mList.getFirstVisiblePosition(); final int lastPos = firstPos + mList.getChildCount() - 1; - int viewTravelCount = 0; + int viewTravelCount; if (position <= firstPos) { viewTravelCount = firstPos - position + 1; mMode = MOVE_UP_POS; diff --git a/Clover/app/src/main/java/org/floens/chan/ui/adapter/PinnedAdapter.java b/Clover/app/src/main/java/org/floens/chan/ui/adapter/PinnedAdapter.java index e8fd4838..16859abe 100644 --- a/Clover/app/src/main/java/org/floens/chan/ui/adapter/PinnedAdapter.java +++ b/Clover/app/src/main/java/org/floens/chan/ui/adapter/PinnedAdapter.java @@ -48,7 +48,7 @@ public class PinnedAdapter extends ArrayAdapter { public View getView(int position, View convertView, ViewGroup parent) { LayoutInflater inflater = (LayoutInflater) getContext().getSystemService(Context.LAYOUT_INFLATER_SERVICE); - LinearLayout view = null; + LinearLayout view; final Pin item = getItem(position); diff --git a/Clover/app/src/main/java/org/floens/chan/ui/fragment/PostRepliesFragment.java b/Clover/app/src/main/java/org/floens/chan/ui/fragment/PostRepliesFragment.java index 5cc4e400..1e9827e0 100644 --- a/Clover/app/src/main/java/org/floens/chan/ui/fragment/PostRepliesFragment.java +++ b/Clover/app/src/main/java/org/floens/chan/ui/fragment/PostRepliesFragment.java @@ -115,7 +115,7 @@ public class PostRepliesFragment extends DialogFragment { ArrayAdapter adapter = new ArrayAdapter(getActivity(), 0) { @Override public View getView(int position, View convertView, ViewGroup parent) { - PostView postView = null; + PostView postView; if (convertView instanceof PostView) { postView = (PostView) convertView; } else { diff --git a/Clover/app/src/main/java/org/floens/chan/ui/fragment/ThreadFragment.java b/Clover/app/src/main/java/org/floens/chan/ui/fragment/ThreadFragment.java index 402a01c7..bf206e55 100644 --- a/Clover/app/src/main/java/org/floens/chan/ui/fragment/ThreadFragment.java +++ b/Clover/app/src/main/java/org/floens/chan/ui/fragment/ThreadFragment.java @@ -248,7 +248,7 @@ public class ThreadFragment extends Fragment implements ThreadManager.ThreadMana } private String getLoadErrorText(VolleyError error) { - String errorMessage = "error"; + String errorMessage; if ((error instanceof NoConnectionError) || (error instanceof NetworkError)) { errorMessage = getActivity().getString(R.string.thread_load_failed_network); diff --git a/Clover/app/src/main/java/org/floens/chan/utils/IOUtils.java b/Clover/app/src/main/java/org/floens/chan/utils/IOUtils.java index 5b0453f0..1e7ff38d 100644 --- a/Clover/app/src/main/java/org/floens/chan/utils/IOUtils.java +++ b/Clover/app/src/main/java/org/floens/chan/utils/IOUtils.java @@ -48,7 +48,7 @@ public class IOUtils { * @throws IOException */ public static void copy(InputStream is, OutputStream os) throws IOException { - int read = 0; + int read; byte[] buffer = new byte[4096]; while ((read = is.read(buffer)) != -1) { os.write(buffer, 0, read); @@ -60,7 +60,7 @@ public class IOUtils { public static void copy(Reader input, Writer output) throws IOException { char[] buffer = new char[4096]; - int read = 0; + int read; while ((read = input.read(buffer)) != -1) { output.write(buffer, 0, read); } diff --git a/Clover/app/src/main/java/org/floens/chan/utils/ImageDecoder.java b/Clover/app/src/main/java/org/floens/chan/utils/ImageDecoder.java index 1e9b5a3f..d0631708 100644 --- a/Clover/app/src/main/java/org/floens/chan/utils/ImageDecoder.java +++ b/Clover/app/src/main/java/org/floens/chan/utils/ImageDecoder.java @@ -67,7 +67,7 @@ public class ImageDecoder { public static Bitmap decode(byte[] data, int maxWidth, int maxHeight) { BitmapFactory.Options decodeOptions = new BitmapFactory.Options(); - Bitmap bitmap = null; + Bitmap bitmap; // If we have to resize this image, first get the natural bounds. decodeOptions.inJustDecodeBounds = true; diff --git a/Clover/app/src/main/java/org/floens/chan/utils/ImageSaver.java b/Clover/app/src/main/java/org/floens/chan/utils/ImageSaver.java index ef4b9b75..69978a53 100644 --- a/Clover/app/src/main/java/org/floens/chan/utils/ImageSaver.java +++ b/Clover/app/src/main/java/org/floens/chan/utils/ImageSaver.java @@ -69,7 +69,7 @@ public class ImageSaver { finalFolder.mkdirs(); for (Uri uri : list) { - DownloadManager.Request request = null; + DownloadManager.Request request; try { request = new DownloadManager.Request(uri); } catch (IllegalArgumentException e) {