Better categorize Volley errors

multisite
Floens 10 years ago
parent c295072f35
commit 373db0aa57
  1. 5
      Clover/app/src/main/java/org/floens/chan/ui/layout/ThreadLayout.java
  2. 7
      Clover/app/src/main/java/org/floens/chan/ui/view/ThumbnailView.java
  3. 2
      Clover/app/src/main/res/values/strings.xml

@ -39,8 +39,9 @@ import android.widget.LinearLayout;
import android.widget.TextView;
import android.widget.Toast;
import com.android.volley.AuthFailureError;
import com.android.volley.NetworkError;
import com.android.volley.NoConnectionError;
import com.android.volley.ParseError;
import com.android.volley.ServerError;
import com.android.volley.TimeoutError;
import com.android.volley.VolleyError;
@ -213,7 +214,7 @@ public class ThreadLayout extends CoordinatorLayout implements ThreadPresenter.T
String errorMessage;
if (error.getCause() instanceof SSLException) {
errorMessage = getContext().getString(R.string.thread_load_failed_ssl);
} else if ((error instanceof NoConnectionError) || (error instanceof NetworkError) || (error instanceof TimeoutError)) {
} else if (error instanceof NetworkError || error instanceof TimeoutError || error instanceof ParseError || error instanceof AuthFailureError) {
errorMessage = getContext().getString(R.string.thread_load_failed_network);
} else if (error instanceof ServerError) {
errorMessage = getContext().getString(R.string.thread_load_failed_server);

@ -33,13 +33,16 @@ import android.text.TextUtils;
import android.util.AttributeSet;
import android.view.View;
import com.android.volley.AuthFailureError;
import com.android.volley.NetworkError;
import com.android.volley.NoConnectionError;
import com.android.volley.ParseError;
import com.android.volley.TimeoutError;
import com.android.volley.VolleyError;
import com.android.volley.toolbox.ImageLoader;
import org.floens.chan.Chan;
import org.floens.chan.R;
import org.floens.chan.utils.Logger;
import static org.floens.chan.utils.AndroidUtils.getString;
import static org.floens.chan.utils.AndroidUtils.sp;
@ -163,7 +166,7 @@ public class ThumbnailView extends View implements ImageLoader.ImageListener {
public void onErrorResponse(VolleyError e) {
error = true;
if ((e instanceof NoConnectionError) || (e instanceof NetworkError)) {
if (e instanceof NetworkError || e instanceof TimeoutError || e instanceof ParseError || e instanceof AuthFailureError) {
errorText = getString(R.string.thumbnail_load_failed_network);
} else {
errorText = getString(R.string.thumbnail_load_failed_server);

@ -104,7 +104,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
<string name="thread_board_select_add">Add more&#8230;</string>
<string name="thread_load_failed_ssl">HTTPS error</string>
<string name="thread_load_failed_network">No network</string>
<string name="thread_load_failed_network">Network error</string>
<string name="thread_load_failed_parsing">API parse error</string>
<string name="thread_load_failed_server">404 not found</string>
<string name="thread_refresh_bar_inactive">Tap to refresh</string>

Loading…
Cancel
Save