mirror of https://github.com/kurisufriend/Clover
I've gotten the freeze three times total on my phone, and this time I was near a computer to do some debugging. This is what I found. Clover uses the ViewTreeObserver in some places to wait for the layout phase to be done and then use the calculated views to do some second calculations. This is not always necessary and I've removed/changed code that used it needlessly. I used this mostly out of laziness to create a new view to implement onMeasure, and not having a good understanding of the measure system. This is bad for performance because a second measure pass is not needed most of the time. I've misinterpreted the meaning of the return value of onPreDrawListener. I thought false meant continue with the rendering, true to request a new layout phase. This was the other way around and has been switched on all pieces of code that used it wrong. A perfect example was the use of waitForLayout in the DrawerController. It would wait for a layout pass to get the total width of the containing view and change the width of the drawer. It also used the wrong return value so the layout was not triggered again when needed and triggeded when not needed. This is now fixed and an issue where the drawer width was wrong is now also fixed. Secondly (and this has been an issue before), the listener would not get removed from the correct ViewTreeObserver in some cases, causing the listener to be triggered on every draw call. This is because Android creates a temporary ViewTreeObserver when a view is not attached to the window, and the callbacks are copied to a real ViewTreeObserver when the view gets attached. I'm still unsure why that does not work sometimes. The final trigger of the bug was the measure callback that was placed on the width of the menu width on the toolbar (the things that switches the boards). This callback always returned false (thinking that was do not cancel) and canceled the draw every time. This is not harmful normally but when the listener is not removed because the ViewTreeObserver is temporary it would get stuck in an endless loop. The weird thing is that touch handling still works correctly when Android gets stuck in such an endless loop. This was why you could still press the reply button and the keyboard would show up. It just doesn't get to the draw phase and then appears to look stuck. I've placed some debug logs in the callbacks when the listener doesn't get removed, and it raises an IllegalArgumentException when the ViewTreeObserver is temporarily.multisite
Floens
10 years ago
parent
69bfe55b04
commit
262f34dfc1
@ -0,0 +1,41 @@ |
||||
package org.floens.chan.ui.layout; |
||||
|
||||
import android.content.Context; |
||||
import android.support.v4.widget.DrawerLayout; |
||||
import android.util.AttributeSet; |
||||
import android.view.View; |
||||
|
||||
import org.floens.chan.R; |
||||
|
||||
import static org.floens.chan.utils.AndroidUtils.dp; |
||||
|
||||
public class DrawerWidthAdjustingLayout extends DrawerLayout { |
||||
public DrawerWidthAdjustingLayout(Context context) { |
||||
super(context); |
||||
} |
||||
|
||||
public DrawerWidthAdjustingLayout(Context context, AttributeSet attrs) { |
||||
super(context, attrs); |
||||
} |
||||
|
||||
public DrawerWidthAdjustingLayout(Context context, AttributeSet attrs, int defStyle) { |
||||
super(context, attrs, defStyle); |
||||
} |
||||
|
||||
@Override |
||||
protected void onMeasure(int widthMeasureSpec, int heightMeasureSpec) { |
||||
// int widthMode = MeasureSpec.getMode(widthMeasureSpec);
|
||||
// int heightMode = MeasureSpec.getMode(heightMeasureSpec);
|
||||
int widthSize = MeasureSpec.getSize(widthMeasureSpec); |
||||
// int heightSize = MeasureSpec.getSize(heightMeasureSpec);
|
||||
|
||||
View drawer = findViewById(R.id.drawer); |
||||
|
||||
int width = Math.min(widthSize - dp(56), dp(56) * 6); |
||||
if (drawer.getLayoutParams().width != width) { |
||||
drawer.getLayoutParams().width = width; |
||||
} |
||||
|
||||
super.onMeasure(widthMeasureSpec, heightMeasureSpec); |
||||
} |
||||
} |
||||
Loading…
Reference in new issue